fix: enforce role hierarchy on permission edits

This commit is contained in:
wren
2026-05-25 10:13:48 +08:00
parent f6c79fa44d
commit fe424761e2
3 changed files with 57 additions and 2 deletions
@@ -1212,6 +1212,7 @@ class RbacAdminServiceImpl(IRbacAdminService):
routeIds = sorted(set(Body.route_ids))
async with GetAsyncSession() as Session:
await self._getAdminRouteMap(Session, EnsureSeeds=True)
await self._assertCanManageTargetRole(Session, CurrentUserId, RoleId)
result = await self._updateRoleRoutesInSession(Session, RoleId, routeIds, Body.permission)
await Session.commit()
PermissionServiceImpl.InvalidateAll()
@@ -1243,6 +1244,7 @@ class RbacAdminServiceImpl(IRbacAdminService):
await self._assertManageAndPermission(CurrentUserId, "rbac:role_permissions:write")
async with GetAsyncSession() as Session:
await self._getAdminRouteMap(Session, EnsureSeeds=True)
await self._assertCanManageTargetRole(Session, CurrentUserId, Body.role_id)
await self._saveRolePermissionsInSession(Session, Body.role_id, Body.permissions, Body.replace, Body.replace_scope_permission_ids)
await Session.commit()
PermissionServiceImpl.InvalidateAll()
@@ -1259,6 +1261,7 @@ class RbacAdminServiceImpl(IRbacAdminService):
]
async with GetAsyncSession() as Session:
await self._getAdminRouteMap(Session, EnsureSeeds=True)
await self._assertCanManageTargetRole(Session, CurrentUserId, RoleId)
routeResult = await self._updateRoleRoutesInSession(Session, RoleId, routeIds, Body.route_permission)
await self._saveRolePermissionsInSession(Session, RoleId, permissionConfigs, True, Body.replace_scope_permission_ids)
permissionResult = await self._getRolePermissionsInSession(Session, RoleId)
@@ -1539,7 +1542,8 @@ class RbacAdminServiceImpl(IRbacAdminService):
{tenant_name_select},
COALESCE(bool_or(r.role_key IN ('super_admin', 'provincial_admin')), FALSE) AS is_global,
COALESCE(bool_or(r.role_key IN ('super_admin', 'provincial_admin', 'admin')), FALSE) AS can_manage,
COALESCE(bool_or(r.role_key = 'super_admin'), FALSE) AS is_super_admin
COALESCE(bool_or(r.role_key = 'super_admin'), FALSE) AS is_super_admin,
COALESCE(MAX(COALESCE(r.priority, 0)), 0) AS max_role_priority
FROM sso_users u
LEFT JOIN user_role ur ON ur.user_id = u.id
LEFT JOIN roles r ON r.id = ur.role_id
@@ -1566,6 +1570,7 @@ class RbacAdminServiceImpl(IRbacAdminService):
"is_global": bool(row["is_global"]),
"can_manage": bool(row["can_manage"]),
"is_super_admin": bool(row["is_super_admin"]),
"max_role_priority": int(row["max_role_priority"] or 0),
}
async def _resolve_requested_scope(self, Session, RawValue: str | None) -> dict[str, str]:
@@ -1869,6 +1874,21 @@ class RbacAdminServiceImpl(IRbacAdminService):
raise LeauditException(StatusCodeEnum.HTTP_404_NOT_FOUND, "角色不存在")
return row
async def _assertCanManageTargetRole(self, Session, CurrentUserId: int, RoleId: int) -> None:
"""禁止低优先级角色编辑更高优先级角色的权限配置。"""
context = await self._getCurrentUserContext(CurrentUserId)
if context.get("is_super_admin"):
return
target = await self._getRoleRow(Session, RoleId)
currentPriority = int(context.get("max_role_priority") or 0)
targetPriority = int(target.get("priority") or 0)
if targetPriority > currentPriority:
raise LeauditException(
StatusCodeEnum.HTTP_403_FORBIDDEN,
"下级角色不可编辑上级角色的路由权限",
)
def _toRoleVo(self, Row) -> RoleVO:
"""角色记录转 VO。"""
return RoleVO(